hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-25 00:27:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix code review finding

Browse Source
This commit is contained in:
Tamas Vajk
2024-11-19 18:06:35 +01:00
parent 28a5634615
commit 39aefb8d17
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/kotlin-extractor2/src/main/kotlin/entities/Expression.kt
View File

@@ -1741,9 +1741,7 @@ private fun KotlinFileExtractor.extractIf(
stmtExprParent: StmtExprParent,
callable: Label<out DbCallable>
): Label<out DbExpr>? {
val expressionType = ifStmt.expressionType
if (expressionType?.isNothingType == true) {
if (!ifStmt.isUsedAsExpression) {
// We're extracting this `if` as a statement
val stmtParent = stmtExprParent.stmt(ifStmt, callable)
val id = tw.getFreshIdLabel<DbIfstmt>()
@@ -1764,7 +1762,7 @@ private fun KotlinFileExtractor.extractIf(
// We're extracting this `if` as a conditional expression
val exprParent = stmtExprParent.expr(ifStmt, callable)
val id = tw.getFreshIdLabel<DbConditionalexpr>()
val type = useType(expressionType)
val type = useType(ifStmt.expressionType)
tw.writeExprs_conditionalexpr(id, type.javaResult.id, exprParent.parent, exprParent.idx)
tw.writeExprsKotlinType(id, type.kotlinResult.id)