hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

[CPP-434] Change list items to ordinary paragraphs in the Recommendation section.

Browse Source
This commit is contained in:
Ziemowit Laski
2019-11-04 16:44:31 -08:00
parent ce8ba86f2d
commit 398896a4b2
1 changed files with 14 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
cpp/ql/src/Likely Bugs/Arithmetic/SignedOverflowCheck.qhelp
View File

@@ -22,34 +22,35 @@ categories: (1) rewrite the signed expression so that overflow cannot occur
but the signedness remains, or (2) rewrite (or cast) the signed expression
into unsigned form.
The bullet list below lists various expressions where signed overflow may
occur, along with proposed rewritings. It should not be
Below we list examples of expressions where signed overflow may
occur, along with proposed solutions. The list should not be
considered exhaustive.
</p>
<li>Given <code>unsigned short i, delta</code> and <code>i + delta &lt; i</code>,
<p>
Given <code>unsigned short i, delta</code> and <code>i + delta &lt; i</code>,
it is possible to rewrite it as <code>(unsigned short)(i + delta)&nbsp;&lt;&nbsp;i</code>.
Note that <code>i + delta</code>does not actually overflow, due to <code>int</code> promotion</li>
Note that <code>i + delta</code>does not actually overflow, due to <code>int</code> promotion
<li>Given <code>unsigned short i, delta</code> and <code>i + delta &lt; i</code>,
Given <code>unsigned short i, delta</code> and <code>i + delta &lt; i</code>,
it is also possible to rewrite it as <code>USHORT_MAX - delta</code>. It must be true
that <code>delta &gt; 0</code> and the <code>limits.h</code> or <code>climits</code>
header has been included.</li>
header has been included.
<li>Given <code>int i, delta</code> and <code>i + delta &lt; i</code>,
Given <code>int i, delta</code> and <code>i + delta &lt; i</code>,
it is possible to rewrite it as <code>INT_MAX - delta</code>. It must be true
that <code>delta &gt; 0</code> and the <code>limits.h</code> or <code>climits</code>
header has been included.</li>
header has been included.
<li>Given <code>int i, delta</code> and <code>i + delta &lt; i</code>,
Given <code>int i, delta</code> and <code>i + delta &lt; i</code>,
it is also possible to rewrite it as <code>(unsigned)i + delta &lt; i</code>.
Note that program semantics are affected by this change.</li>
Note that program semantics are affected by this change.
<li>Given <code>int i, delta</code> and <code>i + delta &lt; i</code>,
Given <code>int i, delta</code> and <code>i + delta &lt; i</code>,
it is also possible to rewrite it as <code>unsigned int i, delta</code> and
<code>i + delta &lt; i</code>. Note that program semantics are
affected by this change.</li>
affected by this change.
</p>
</recommendation>
<example>