hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 03:36:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Show virtual inheritance problem in vdispatch

Browse Source
This commit is contained in:
Jonas Jensen
2020-01-20 11:17:44 +01:00
parent 2a0fc31b68
commit 391b80eac4
1 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
cpp/ql/test/library-tests/dataflow/dataflow-tests/dispatch.cpp
View File

@@ -107,3 +107,26 @@ void testFunctionPointer(SinkFunctionType maybeCallSink, SinkFunctionType dontCa
maybeCallSink(source()); // flow [NOT DETECTED by AST] maybeCallSink(source()); // flow [NOT DETECTED by AST]
dontCallSink(source()); // no flow dontCallSink(source()); // no flow
} }
namespace virtual_inheritance {
struct Top {
virtual int isSource() { return 0; }
};
struct Middle : virtual Top {
int isSource() override { return source(); }
};
struct Bottom : Middle {
};
void VirtualDispatch(Bottom *bottomPtr, Bottom &bottomRef) {
// Because the inheritance from `Top` is virtual, the following casts go
// directly from `Bottom` to `Top`, skipping `Middle`. That means we don't
// get flow from a `Middle` value to the call qualifier.
Top *topPtr = bottomPtr, &topRef = bottomRef;
sink(topPtr->isSource()); // flow [NOT DETECTED]
sink(topRef.isSource()); // flow [NOT DETECTED]
}
}