From fc4afe6eb210106e33e8df2acc17e661817a3dfb Mon Sep 17 00:00:00 2001 From: Max Schaefer Date: Fri, 21 Feb 2020 09:14:00 +0000 Subject: [PATCH 1/2] JavaScript: Improve qldoc for `Parameter` to clarify that it also contains catch-clause parameters. --- javascript/ql/src/semmle/javascript/Variables.qll | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/javascript/ql/src/semmle/javascript/Variables.qll b/javascript/ql/src/semmle/javascript/Variables.qll index 2c6e7b32647..d83692936f8 100644 --- a/javascript/ql/src/semmle/javascript/Variables.qll +++ b/javascript/ql/src/semmle/javascript/Variables.qll @@ -680,7 +680,7 @@ class Parameterized extends @parameterized, Documentable { } /** - * A parameter declaration. + * A parameter declaration in a function or catch clause. * * Examples: * @@ -688,6 +688,9 @@ class Parameterized extends @parameterized, Documentable { * function f(x, { y: z }, ...rest) { // `x`, `{ y: z }` and `rest` are parameter declarations * var [ a, b ] = rest; * var c; + * try { +* x.m(); + * } catch(e) {} // `e` is a parameter declaration * } * ``` */ From 75495d7aad457a5909336e299405b6df217d5c9b Mon Sep 17 00:00:00 2001 From: Max Schaefer <54907921+max-schaefer@users.noreply.github.com> Date: Fri, 21 Feb 2020 10:06:32 +0000 Subject: [PATCH 2/2] Update javascript/ql/src/semmle/javascript/Variables.qll Co-Authored-By: Asger F --- javascript/ql/src/semmle/javascript/Variables.qll | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/javascript/ql/src/semmle/javascript/Variables.qll b/javascript/ql/src/semmle/javascript/Variables.qll index d83692936f8..df4dccaf987 100644 --- a/javascript/ql/src/semmle/javascript/Variables.qll +++ b/javascript/ql/src/semmle/javascript/Variables.qll @@ -689,7 +689,7 @@ class Parameterized extends @parameterized, Documentable { * var [ a, b ] = rest; * var c; * try { -* x.m(); + * x.m(); * } catch(e) {} // `e` is a parameter declaration * } * ```