hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: review comments

Browse Source
This commit is contained in:
Asger F
2019-04-03 14:18:06 +01:00
parent 07d508d1bf
commit 37fa2446d4
3 changed files with 11 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/src/semmle/javascript/dataflow/Configuration.qll
View File

@@ -242,12 +242,6 @@ module FlowLabel {
* source, but not necessarily directly derived from it.
*/
FlowLabel taint() { result = "taint" }
/**
* Gets one of the two standard flow labels, `data` or `taint`, describing values that originate
* from a flow source or are derived from a flow source.
*/
FlowLabel dataOrTaint() { result = data() or result = taint() }
}
/**

10
javascript/ql/src/semmle/javascript/security/dataflow/TaintedPath.qll
View File

@@ -23,7 +23,7 @@ module TaintedPath {
module Label {
/**
* String indicating if a path is normalized, that is, whether internal `../` components
* A string indicating if a path is normalized, that is, whether internal `../` components
* have been removed.
*/
class Normalization extends string {
@@ -31,7 +31,7 @@ module TaintedPath {
}
/**
* String indicating if a path is relative or absolute.
* A string indicating if a path is relative or absolute.
*/
class Relativeness extends string {
Relativeness() { this = "relative" or this = "absolute" }
@@ -108,7 +108,7 @@ module TaintedPath {
PosixPath toPosixPath(DataFlow::FlowLabel label) {
result = label
or
label = DataFlow::FlowLabel::dataOrTaint()
label instanceof DataFlow::StandardFlowLabel
}
}
@@ -270,7 +270,7 @@ module TaintedPath {
* Holds if `s` is a relative path.
*/
bindingset[s]
private predicate isRelative(string s) { not s = "/" + any(string q) }
private predicate isRelative(string s) { not s.charAt(0) = "/" }
/**
* A call that normalizes a path.
@@ -375,7 +375,7 @@ module TaintedPath {
input = getReceiver() and
output = this and
not exists(RegExpLiteral literal, RegExpSequence seq |
getArgument(0).asExpr() = literal and
getArgument(0).getALocalSource().asExpr() = literal and
literal.isGlobal() and
literal.getRoot() = seq and
seq.getChild(0).(RegExpConstant).getValue() = "." and

12
javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/normalizedPaths.js
View File

@@ -223,11 +223,11 @@ app.get('/decode-after-normalization', (req, res) => {
});
app.get('/replace', (req, res) => {
let path = pathModule.normalize(req.query.path).replace(/%20/g, ' ');
if (!pathModule.isAbsolute(path)) {
res.sendFile(path); // NOT OK
let path = pathModule.normalize(req.query.path).replace(/%20/g, ' ');
if (!pathModule.isAbsolute(path)) {
res.sendFile(path); // NOT OK
path = path.replace(/\.\./g, '');
res.sendFile(path); // OK
}
path = path.replace(/\.\./g, '');
res.sendFile(path); // OK
}
});