hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant models and corresponding test

Browse Source 
Iterator.next is already modelled
This commit is contained in:
Owen Mansel-Chan
2021-08-04 15:57:13 +01:00
parent 5d3f10824e
commit 377403d525
2 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/ql/src/semmle/code/java/frameworks/apache/Collections.qll
View File

@@ -88,7 +88,6 @@ private class ApacheCollectionsModel extends SummaryModelCsv {
// In order for the models of Iterator to work we have to use Element instead of MapKey for key data.
"org.apache.commons.collections4;MapIterator;true;getKey;;;Element of Argument[-1];ReturnValue;value",
"org.apache.commons.collections4;MapIterator;true;getValue;;;MapValue of Argument[-1];ReturnValue;value",
"org.apache.commons.collections4;MapIterator;true;next;;;Element of Argument[-1];ReturnValue;value",
"org.apache.commons.collections4;MapIterator;true;setValue;;;MapValue of Argument[-1];ReturnValue;value",
"org.apache.commons.collections4;MapIterator;true;setValue;;;Argument[0];MapValue of Argument[-1];value",
"org.apache.commons.collections4;MultiMap;true;get;;;Element of MapValue of Argument[-1];Element of ReturnValue;value",
@@ -177,7 +176,6 @@ private class ApacheCollectionsModel extends SummaryModelCsv {
"org.apache.commons.collections;KeyValue;true;getValue;;;MapValue of Argument[-1];ReturnValue;value",
"org.apache.commons.collections;MapIterator;true;getKey;;;Element of Argument[-1];ReturnValue;value",
"org.apache.commons.collections;MapIterator;true;getValue;;;MapValue of Argument[-1];ReturnValue;value",
"org.apache.commons.collections;MapIterator;true;next;;;Element of Argument[-1];ReturnValue;value",
"org.apache.commons.collections;MapIterator;true;setValue;;;MapValue of Argument[-1];ReturnValue;value",
"org.apache.commons.collections;MapIterator;true;setValue;;;Argument[0];MapValue of Argument[-1];value",
"org.apache.commons.collections;MultiMap;true;get;;;Element of MapValue of Argument[-1];Element of ReturnValue;value",

7
java/ql/test/library-tests/frameworks/apache-collections/Test.java
View File

@@ -2675,13 +2675,6 @@ public class Test {
out = in.getValue();
sink(out); // $ hasValueFlow
}
{
// "org.apache.commons.collections4;MapIterator;true;next;;;Element of Argument[-1];ReturnValue;value"
Object out = null;
MapIterator in = newOMIWithElement((String)source());
out = in.next();
sink(out); // $ hasValueFlow
}
{
// "org.apache.commons.collections4;MapIterator;true;setValue;;;Argument[0];MapValue of Argument[-1];value"
MapIterator out = null;