hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 04:39:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

apply manual magic in both cases in maybeAssignsAccessedPropInBlock

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-08-11 14:24:49 +02:00
parent eccfade928
commit 374b1b7b97
1 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
javascript/ql/src/Declarations/DeadStoreOfProperty.ql
View File

@@ -115,20 +115,22 @@ predicate maybeAssignsAccessedPropInBlock(DataFlow::PropWrite assign, boolean af
or
after = false and postDominatedPropWrite(_, _, assign, false)
) and
exists(ReachableBasicBlock block, int i, int j, Expr e, string name |
i = getRank(block, assign.getWriteNode(), name) and
j = getRank(block, e, name) and
isAPropertyRead(e, name)
|
after = true and i < j
(
exists(ReachableBasicBlock block, int i, int j, Expr e, string name |
i = getRank(block, assign.getWriteNode(), name) and
j = getRank(block, e, name) and
isAPropertyRead(e, name)
|
after = true and i < j
or
after = false and j < i
)
or
after = false and j < i
)
or
exists(ReachableBasicBlock block | assign.getWriteNode().getBasicBlock() = block |
after = true and isBeforeImpure(assign, block)
or
after = false and isAfterImpure(assign, block)
exists(ReachableBasicBlock block | assign.getWriteNode().getBasicBlock() = block |
after = true and isBeforeImpure(assign, block)
or
after = false and isAfterImpure(assign, block)
)
)
}