From 368227fff5d039bb4d49669d04520fb947fea025 Mon Sep 17 00:00:00 2001 From: Max Schaefer Date: Mon, 24 Aug 2020 17:04:55 +0100 Subject: [PATCH] Fix tests for `NegativeLengthCheck`. --- .../NegativeLengthCheck/NegativeLengthCheck.expected | 1 - ql/test/query-tests/RedundantCode/NegativeLengthCheck/main.go | 4 ---- 2 files changed, 5 deletions(-) diff --git a/ql/test/query-tests/RedundantCode/NegativeLengthCheck/NegativeLengthCheck.expected b/ql/test/query-tests/RedundantCode/NegativeLengthCheck/NegativeLengthCheck.expected index 33a060bb930..e6cf7853e39 100644 --- a/ql/test/query-tests/RedundantCode/NegativeLengthCheck/NegativeLengthCheck.expected +++ b/ql/test/query-tests/RedundantCode/NegativeLengthCheck/NegativeLengthCheck.expected @@ -4,4 +4,3 @@ | main.go:18:5:18:22 | ...<=... | 'len' is always non-negative, and hence cannot be less than -1. | | main.go:22:5:22:22 | ...==... | 'len' is always non-negative, and hence cannot equal -1. | | main.go:28:9:28:13 | ...<... | This unsigned value is always non-negative, and hence cannot be less than 0. | -| main.go:36:9:36:15 | ...==... | This unsigned value is always non-negative, and hence cannot equal -1. | diff --git a/ql/test/query-tests/RedundantCode/NegativeLengthCheck/main.go b/ql/test/query-tests/RedundantCode/NegativeLengthCheck/main.go index e97bf93b208..f43f4851c5f 100644 --- a/ql/test/query-tests/RedundantCode/NegativeLengthCheck/main.go +++ b/ql/test/query-tests/RedundantCode/NegativeLengthCheck/main.go @@ -31,7 +31,3 @@ func checkNegative(x uint) bool { func checkNonPositive(x uint) bool { return x <= 0 // OK } - -func checkIsMinusOne(x uint) bool { - return x == -1 // NOT OK -}