hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Codegen: remove unneeded has|getNumberOf in instance tests

Browse Source
This commit is contained in:
Paolo Tranquilli
2025-06-25 12:02:13 +02:00
parent 6bbf1e3bc1
commit 355fd85c23
407 changed files with 1294 additions and 3572 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
misc/codegen/generators/qlgen.py
View File

@@ -361,10 +361,6 @@ def _get_all_properties_to_be_tested(
type=p.type if not p.is_predicate else None,
is_indexed=p.is_indexed,
)
if p.is_repeated and not p.is_optional:
yield ql.PropertyForTest(f"getNumberOf{p.plural}", type="int")
elif p.is_optional and not p.is_repeated:
yield ql.PropertyForTest(f"has{p.singular}")
def _partition_iter(x, pred):

4
misc/codegen/test/test_qlgen.py
View File

@@ -1038,16 +1038,13 @@ def test_test_partial_properties(opts, generate_tests):
class_name="B",
properties=[
ql.PropertyForTest(getter="getX", is_total=False, type="string"),
ql.PropertyForTest(getter="hasX"),
ql.PropertyForTest(
getter="getY", is_total=False, is_indexed=True, type="bool"
),
ql.PropertyForTest(getter="getNumberOfYs", type="int"),
ql.PropertyForTest(
getter="getZ", is_total=False, is_indexed=True, type="int"
),
ql.PropertyForTest(getter="getAW", is_total=False, type="string"),
ql.PropertyForTest(getter="getNumberOfWs", type="int"),
],
),
}
@@ -1077,7 +1074,6 @@ def test_test_properties_deduplicated(opts, generate_tests):
ql.PropertyForTest(
getter="getY", is_total=False, is_indexed=True, type="bool"
),
ql.PropertyForTest(getter="getNumberOfYs", type="int"),
],
),
}