hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: restrict java/non-sync-override to immediate overrides

Browse Source
This commit is contained in:
yh-semmle
2019-10-10 19:55:31 -04:00
parent ff5a98b260
commit 35552a8c0e
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
java/ql/src/Likely Bugs/Concurrency/NonSynchronizedOverride.ql
View File

@@ -56,6 +56,7 @@ where
sup.isSynchronized() and
not sub.isSynchronized() and
not delegatingOverride(sub, sup) and
not exists(Method mid | sub.overrides(mid) and mid.overrides(sup)) and
supSrc = sup.getDeclaringType().getSourceDeclaration()
select sub,
"Method '" + sub.getName() + "' overrides a synchronized method in $@ but is not synchronized.",