hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 09:43:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Modernise py/unused-parameter

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2019-12-17 16:23:33 +01:00
parent 15bc4cd090
commit 34f9135492
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
python/ql/src/Variables/UnusedParameter.ql
View File

@@ -13,19 +13,19 @@ import python
import Definition
predicate unused_parameter(FunctionObject f, LocalVariable v) {
predicate unused_parameter(FunctionValue f, LocalVariable v) {
v.isParameter() and
v.getScope() = f.getFunction() and
v.getScope() = f.getScope() and
not name_acceptable_for_unused_variable(v) and
not exists(NameNode u | u.uses(v)) and
not exists(Name inner, LocalVariable iv | inner.uses(iv) and iv.getId() = v.getId() and inner.getScope().getScope() = v.getScope())
}
predicate is_abstract(FunctionObject func) {
((Name)func.getFunction().getADecorator()).getId().matches("%abstract%")
predicate is_abstract(FunctionValue func) {
func.getScope().getADecorator().(Name).getId().matches("%abstract%")
}
from PyFunctionObject f, LocalVariable v
from PythonFunctionValue f, LocalVariable v
where v.getId() != "self" and unused_parameter(f, v) and not f.isOverridingMethod() and not f.isOverriddenMethod() and
not is_abstract(f)
select f, "The parameter '" + v.getId() + "' is never used."