hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-04 05:05:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

CPP: Test a common false positive.

Browse Source
This commit is contained in:
Geoffrey White
2019-07-01 14:56:28 +01:00
parent a54ee160a3
commit 34d307ecef
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
cpp/ql/test/query-tests/Security/CWE/CWE-131/semmle/NoSpaceForZeroTerminator/NoSpaceForZeroTerminator.expected
View File

@@ -1,4 +1,5 @@
| test.c:15:20:15:25 | call to malloc | This allocation does not include space to null-terminate the string. |
| test.c:29:20:29:25 | call to malloc | This allocation does not include space to null-terminate the string. |
| test.c:44:20:44:25 | call to malloc | This allocation does not include space to null-terminate the string. |
| test.c:72:17:72:22 | call to malloc | This allocation does not include space to null-terminate the string. |
| test.cpp:18:35:18:40 | call to malloc | This allocation does not include space to null-terminate the string. |

12
cpp/ql/test/query-tests/Security/CWE/CWE-131/semmle/NoSpaceForZeroTerminator/test.c
View File

@@ -63,3 +63,15 @@ void good3(char *str) {
char *buffer = malloc((strlen(str) + 1) * sizeof(char));
free(buffer);
}
void *memcpy(void *s1, const void *s2, size_t n);
void good4(char *str) {
// GOOD -- allocating a non zero-terminated string [FALSE POSITIVE]
int len = strlen(str);
char *buffer = malloc(len);
memcpy(buffer, str, len);
free(buffer);
}