hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rangeanalysis: Remove superfluous ignoreSsaReadCopy.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2023-10-31 15:32:25 +01:00
parent 322e6c91be
commit 34b9791e46
5 changed files with 1 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/analysis/RangeAnalysisConstantSpecific.qll
View File

@@ -8,14 +8,6 @@ private import RangeAnalysisImpl
private import codeql.rangeanalysis.RangeAnalysis private import codeql.rangeanalysis.RangeAnalysis
module CppLangImplConstant implements LangSig<Sem, FloatDelta> { module CppLangImplConstant implements LangSig<Sem, FloatDelta> {
/**
* Holds if the specified expression should be excluded from the result of `ssaRead()`.
*
* This predicate is to keep the results identical to the original Java implementation. It should be
* removed once we have the new implementation matching the old results exactly.
*/
predicate ignoreSsaReadCopy(SemExpr e) { none() }
/** /**
* Ignore the bound on this expression. * Ignore the bound on this expression.
* *

8
cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/analysis/RangeAnalysisRelativeSpecific.qll
View File

@@ -9,14 +9,6 @@ private import semmle.code.cpp.rangeanalysis.RangeAnalysisUtils
private import codeql.rangeanalysis.RangeAnalysis private import codeql.rangeanalysis.RangeAnalysis
module CppLangImplRelative implements LangSig<Sem, FloatDelta> { module CppLangImplRelative implements LangSig<Sem, FloatDelta> {
/**
* Holds if the specified expression should be excluded from the result of `ssaRead()`.
*
* This predicate is to keep the results identical to the original Java implementation. It should be
* removed once we have the new implementation matching the old results exactly.
*/
predicate ignoreSsaReadCopy(SemExpr e) { none() }
/** /**
* Ignore the bound on this expression. * Ignore the bound on this expression.
* *

3
cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/analysis/RangeUtils.qll
View File

@@ -32,8 +32,7 @@ module RangeUtil<DeltaSig D, LangSig<Sem, D> Lang> implements UtilSig<Sem, D> {
result = v.(SemSsaExplicitUpdate).getSourceExpr() and result = v.(SemSsaExplicitUpdate).getSourceExpr() and
delta = D::fromFloat(0) delta = D::fromFloat(0)
or or
result.(SemCopyValueExpr).getOperand() = semSsaRead(v, delta) and result.(SemCopyValueExpr).getOperand() = semSsaRead(v, delta)
not Lang::ignoreSsaReadCopy(result)
or or
result.(SemStoreExpr).getOperand() = semSsaRead(v, delta) result.(SemStoreExpr).getOperand() = semSsaRead(v, delta)
} }

2
java/ql/lib/semmle/code/java/dataflow/RangeAnalysis.qll
View File

@@ -315,8 +315,6 @@ module IntDelta implements DeltaSig {
} }
module JavaLangImpl implements LangSig<Sem, IntDelta> { module JavaLangImpl implements LangSig<Sem, IntDelta> {
predicate ignoreSsaReadCopy(Sem::Expr e) { none() }
/** /**
* Holds if `e >= bound` (if `upper = false`) or `e <= bound` (if `upper = true`). * Holds if `e >= bound` (if `upper = false`) or `e <= bound` (if `upper = true`).
*/ */

8
shared/rangeanalysis/codeql/rangeanalysis/RangeAnalysis.qll
View File

@@ -250,14 +250,6 @@ signature module DeltaSig {
} }
signature module LangSig<Semantic Sem, DeltaSig D> { signature module LangSig<Semantic Sem, DeltaSig D> {
/**
* Holds if the specified expression should be excluded from the result of `ssaRead()`.
*
* This predicate is to keep the results identical to the original Java implementation. It should be
* removed once we have the new implementation matching the old results exactly.
*/
predicate ignoreSsaReadCopy(Sem::Expr e);
/** /**
* Holds if `e >= bound` (if `upper = false`) or `e <= bound` (if `upper = true`). * Holds if `e >= bound` (if `upper = false`) or `e <= bound` (if `upper = true`).
*/ */