hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Factor out <recommendation> part of qhelp

Browse Source
This commit is contained in:
Asger Feldthaus
2022-02-16 13:44:45 +01:00
parent 8ac0ec8dfc
commit 3496ae131b
3 changed files with 27 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
javascript/ql/src/Security/CWE-918/ClientSideRequestForgery.qhelp
View File

@@ -19,24 +19,7 @@
</p>
</overview>
<recommendation>
<p>
Restrict user inputs in the URL of an outgoing request, in particular:
<ul>
<li>
Avoid user input in the hostname of the URL.
Pick the hostname from an allow-list instead of constructing it directly from user input.
</li>
<li>
Take care when user input is part of the pathname of the URL.
Restrict the input so that path traversal ("<code>../<code>")
cannot be used to redirect the request to an unintended endpoint.
</li>
</ul>
</p>
</recommendation>
<include src="RequestForgeryRecommendation.inc.qhelp"/>
<example>

19
javascript/ql/src/Security/CWE-918/RequestForgery.qhelp
View File

@@ -20,24 +20,7 @@
</p>
</overview>
<recommendation>
<p>
Restrict user inputs in the URL of an outgoing request, in particular:
<ul>
<li>
Avoid user input in the hostname of the URL.
Pick the hostname from an allow-list instead of constructing it directly from user input.
</li>
<li>
Take care when user input is part of the pathname of the URL.
Restrict the input so that path traversal ("<code>../<code>")
cannot be used to redirect the request to an unintended endpoint.
</li>
</ul>
</p>
</recommendation>
<include src="RequestForgeryRecommendation.inc.qhelp"/>
<example>

25
javascript/ql/src/Security/CWE-918/RequestForgeryRecommendation.inc.qhelp Normal file
View File

@@ -0,0 +1,25 @@
<!DOCTYPE qhelp PUBLIC
"-//Semmle//qhelp//EN"
"qhelp.dtd">
<qhelp>
<recommendation>
<p>
Restrict user inputs in the URL of an outgoing request, in particular:
</p>
<ul>
<li>
Avoid user input in the hostname of the URL.
Pick the hostname from an allow-list instead of constructing it directly from user input.
</li>
<li>
Take care when user input is part of the pathname of the URL.
Restrict the input so that path traversal ("<code>../</code>")
cannot be used to redirect the request to an unintended endpoint.
</li>
</ul>
</recommendation>
</qhelp>