hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

change commandExecution sink to CodeInjection sink

Browse Source
This commit is contained in:
amammad
2023-09-22 19:37:17 +10:00
parent 06114d91d8
commit 344869f0d7
4 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
javascript/ql/lib/semmle/javascript/frameworks/NodeJSLib.qll
View File

@@ -6,6 +6,7 @@ import javascript
import semmle.javascript.frameworks.HTTP
import semmle.javascript.security.SensitiveActions
private import semmle.javascript.dataflow.internal.PreCallGraphStep
private import semmle.javascript.security.dataflow.CodeInjectionCustomizations
module NodeJSLib {
private GlobalVariable processVariable() { variables(result, "process", any(GlobalScope sc)) }
@@ -763,16 +764,8 @@ module NodeJSLib {
/**
* The dynamic import expression input can be a `data:` URL which loads any module from that data
*/
class DynamicImport extends SystemCommandExecution, DataFlow::ExprNode {
class DynamicImport extends CodeInjection::Sink, DataFlow::ExprNode {
DynamicImport() { this = any(DynamicImportExpr e).getAChildExpr().flow() }
override DataFlow::Node getACommandArgument() { result = this }
override predicate isShellInterpreted(DataFlow::Node arg) { arg = this }
override predicate isSync() { none() }
override DataFlow::Node getOptionsArg() { none() }
}
/**