hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 12:15:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

accept IO redirections as OK

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-02-19 10:12:24 +01:00
parent 73a7d406a5
commit 344060e139
3 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
javascript/ql/test/query-tests/Security/CWE-078/UselessCat.expected
View File

@@ -1,2 +1,3 @@
| False negative | uselesscat.js:69:42:69:69 | // NOT ... lagged] |
| False positive | uselesscat.js:18:70:18:118 | // OK [ ... jection |
| False positive | uselesscat.js:82:80:82:128 | // OK ( ... / gid)) |

15
javascript/ql/test/query-tests/Security/CWE-078/uselesscat.js
View File

@@ -50,10 +50,10 @@ execSync(cmd); // NOT OK
execSync("cat /proc/cpuinfo | grep -c '" + someValue + "'"); // OK - pipes
function cat(file) {
return execSync('cat ' + file).toString(); // NOT OK [flagged]
return execSync('cat ' + file).toString(); // NOT OK
}
execSync(`cat ${files.join(' ')} > ${outFile}`); // NOT OK [flagged]
execSync(`cat ${files.join(' ')} > ${outFile}`); // OK
var cmd = 'cat package.json | grep'
exec(cmd); // OK - pipes!
@@ -70,4 +70,13 @@ execSync("sh -c 'cat " + newpath + "'"); // NOT OK. [but not flagged]
exec(` cat ${newpath}`) // NOT OK
exec(` cat ${newpath} | grep foo`) // OK - pipes
exec(` cat ${newpath} | grep foo`) // OK - pipes
execSync('cat /proc/cpuinfo > foo/bar/baz').toString(); // OK.
execSync(`cat ${newpath} > ${destpath}`).toString(); // OK.
const Opts = {encoding: 'utf8'}
execSync(`cat foo/bar/${newpath}`, Opts).slice(0, 7); // NOT OK ("encoding" is used EXACTLY the same way in fs.readFileSync)
execSync("/bin/cat /proc/cpuinfo", { uid: 1000, gid: 1000, encoding: 'utf8'}); // OK (fs.readFileSync cannot emulate uid / gid))