hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 10:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Abbreviate isSink

Browse Source
This commit is contained in:
Chris Smowton
2022-02-11 10:33:17 +00:00
parent 80a2b388bf
commit 333130b2a4
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
java/ql/src/experimental/Security/CWE/CWE-208/TimingAttackAgainstHeader.ql
View File

@@ -28,12 +28,6 @@ private predicate isNonConstantEqualsCallArgument(Expr e) {
e = [call.getQualifier(), call.getAnArgument()]
}
class NonConstantTimeComparisonSink extends DataFlow::Node {
NonConstantTimeComparisonSink() {
isNonConstantEqualsCallArgument(this.asExpr())
}
}
class ClientSuppliedIpTokenCheck extends DataFlow::Node {
ClientSuppliedIpTokenCheck() {
exists(MethodAccess ma |
@@ -52,7 +46,7 @@ class NonConstantTimeComparisonConfig extends TaintTracking::Configuration {
override predicate isSource(DataFlow::Node source) { source instanceof ClientSuppliedIpTokenCheck }
override predicate isSink(DataFlow::Node sink) { sink instanceof NonConstantTimeComparisonSink }
override predicate isSink(DataFlow::Node sink) { isNonConstantEqualsCallArgument(sink.asExpr()) }
}
from DataFlow::PathNode source, DataFlow::PathNode sink, NonConstantTimeComparisonConfig conf