hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 20:25:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

JavaScript: Autoformat all QL files.

Browse Source
This commit is contained in:
Max Schaefer
2019-01-07 10:15:45 +00:00
parent aa6b89dc34
commit 31bb39a810
380 changed files with 9957 additions and 13923 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql
View File

@@ -20,11 +20,15 @@ import javascript
class IncrementExpr extends Expr {
IncrementExpr() {
// x += e
this instanceof AssignAddExpr or
this instanceof AssignAddExpr
or
// ++x or x++
this instanceof PreIncExpr or this instanceof PostIncExpr or
this instanceof PreIncExpr
or
this instanceof PostIncExpr
or
// x = x + e
exists (AssignExpr assgn, Variable v | assgn = this |
exists(AssignExpr assgn, Variable v | assgn = this |
assgn.getTarget() = v.getAnAccess() and
assgn.getRhs().(AddExpr).getAnOperand().getUnderlyingReference() = v.getAnAccess()
)
@@ -35,18 +39,17 @@ class IncrementExpr extends Expr {
* Holds if `efl` is a loop whose body increments a variable and does nothing else.
*/
predicate countingLoop(EnhancedForLoop efl) {
exists (ExprStmt inc | inc.getExpr().stripParens() instanceof IncrementExpr |
exists(ExprStmt inc | inc.getExpr().stripParens() instanceof IncrementExpr |
inc = efl.getBody() or
inc = efl.getBody().(BlockStmt).getAStmt()
)
}
from EnhancedForLoop efl, PurelyLocalVariable iter
where iter = efl.getAnIterationVariable() and
not exists (SsaExplicitDefinition ssa | ssa.defines(efl.getIteratorExpr(), iter)) and
exists (ReachableBasicBlock body | body.getANode() = efl.getBody() |
body.getASuccessor+() = body
) and
not countingLoop(efl) and
not iter.getName().toLowerCase().regexpMatch("(_|dummy|unused).*")
select efl.getIterator(), "For loop variable " + iter.getName() + " is not used in the loop body."
where
iter = efl.getAnIterationVariable() and
not exists(SsaExplicitDefinition ssa | ssa.defines(efl.getIteratorExpr(), iter)) and
exists(ReachableBasicBlock body | body.getANode() = efl.getBody() | body.getASuccessor+() = body) and
not countingLoop(efl) and
not iter.getName().toLowerCase().regexpMatch("(_|dummy|unused).*")
select efl.getIterator(), "For loop variable " + iter.getName() + " is not used in the loop body."