hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 04:39:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix comment.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2021-03-04 16:11:47 +01:00
committed by GitHub
parent 6c14288fa7
commit 31690dee58
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
View File

@@ -694,9 +694,9 @@ private predicate simpleInstructionLocalFlowStep(Operand opFrom, Instruction iTo
opFrom.getAnyDef() instanceof WriteSideEffectInstruction and
chi.getPartialOperand() = opFrom and
not chi.isResultConflated() and
// In a call such as `set_value(&x->val);`
// we don't want the memory that of `x` to receive dataflow. This is handled by field flow. If we
// add dataflow here we get field to object flow.
// In a call such as `set_value(&x->val);` we don't want the memory representing `x` to receive
// dataflow by a simple step. Instead, this is handled by field flow. If we add a simple step here
// we can get field-to-object flow.
not chi.isPartialUpdate()
)
or