hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 10:46:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Clean up and extend built-in call node classes

Browse Source
This commit is contained in:
Taus Brock-Nannestad
2020-10-08 14:55:27 +02:00
parent e9ecc00b37
commit 31596ef569
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
python/ql/src/experimental/dataflow/internal/Attributes.qll
View File

@@ -74,7 +74,7 @@ private class BuiltInCallNode extends CallNode {
string name;
BuiltInCallNode() {
// TODO disallow instances where `setattr` may refer to an in-scope variable of that name.
// TODO disallow instances where the name of the built-in may refer to an in-scope variable of that name.
exists(NameNode id | this.getFunction() = id and id.getId() = name and id.isGlobal()) and
name = any(Builtin b).getName()
}
@@ -85,14 +85,10 @@ private class BuiltInCallNode extends CallNode {
/**
* Represents a call to the built-ins that handle dynamic inspection and modification of
* attributes: `getattr`, `setattr`, and `hasattr`.
* attributes: `getattr`, `setattr`, `hasattr`, and `delattr`.
*/
private class BuiltinAttrCallNode extends BuiltInCallNode {
BuiltinAttrCallNode() {
name = "setattr" or
name = "getattr" or
name = "hasattr"
}
BuiltinAttrCallNode() { name in ["setattr", "getattr", "hasattr", "delattr"] }
/** Gets the control flow node for object on which the attribute is accessed. */
ControlFlowNode getObject() { result in [this.getArg(0), this.getArgByName("object")] }