hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 12:15:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6711 from bananabr/AndroidLoggingFix

Browse Source 
Fix Android logging signature
This commit is contained in:
Chris Smowton
2021-09-22 17:23:04 +01:00
committed by GitHub
parent 14a31a2299 24e3ad4e18
commit 3123abfac3
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/ql/src/experimental/semmle/code/java/Logging.qll
View File

@@ -18,8 +18,7 @@ class LoggingCall extends MethodAccess {
t.hasQualifiedName("org.scijava.log", "Logger") or
t.hasQualifiedName("com.google.common.flogger", "LoggingApi") or
t.hasQualifiedName("java.lang", "System$Logger") or
t.hasQualifiedName("java.util.logging", "Logger") or
t.hasQualifiedName("android.util", "Log")
t.hasQualifiedName("java.util.logging", "Logger")
|
(
m.getDeclaringType().getASourceSupertype*() = t or
@@ -28,6 +27,12 @@ class LoggingCall extends MethodAccess {
m.getReturnType() instanceof VoidType and
this = m.getAReference()
)
or
exists(RefType t, Method m | t.hasQualifiedName("android.util", "Log") |
m.hasName(["d", "e", "i", "v", "w", "wtf"]) and
m.getDeclaringType() = t and
this = m.getAReference()
)
}
/** Returns an argument which would be logged by this call. */