hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Also fix the FP in 'cpp/comparison-canceling-subexpr'.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2021-12-14 17:08:10 +00:00
parent b2082cc3da
commit 310353060e
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cpp/ql/src/Likely Bugs/Arithmetic/ComparisonWithCancelingSubExpr.ql
View File

@@ -85,7 +85,8 @@ private predicate cancelingSubExprs(ComparisonOperation cmp, VariableAccess a1,
exists(Variable v |
exists(float m | m < 0 and cmpLinearSubVariable(cmp, v, a1, m)) and
exists(float m | m > 0 and cmpLinearSubVariable(cmp, v, a2, m))
)
) and
not any(ClassTemplateInstantiation inst).getATemplateArgument() = cmp.getParent*()
}
from ComparisonOperation cmp, VariableAccess a1, VariableAccess a2