hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-03-06 07:36:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fix CWE-611 XXE query to work with use-use dataflow

Browse Source
This commit is contained in:
Jeroen Ketema
2022-11-23 16:14:28 +01:00
parent 9e4cab74ec
commit 30bdd25228
2 changed files with 68 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/src/Security/CWE/CWE-611/Xerces.qll
View File

@@ -67,8 +67,7 @@ class XercesDomParserLibrary extends XmlLibrary {
// constructor.
exists(CallInstruction call |
call.getStaticCallTarget() = any(XercesDomParserClass c).getAConstructor() and
node.asInstruction().(WriteSideEffectInstruction).getDestinationAddress() =
call.getThisArgument() and
node.asInstruction().(StoreInstruction).getSourceValue() = call.getThisArgument() and
encodeXercesFlowState(flowstate, 0, 1) // default configuration
)
}
@@ -153,8 +152,7 @@ class SaxParserLibrary extends XmlLibrary {
// constructor.
exists(CallInstruction call |
call.getStaticCallTarget() = any(SaxParserClass c).getAConstructor() and
node.asInstruction().(WriteSideEffectInstruction).getDestinationAddress() =
call.getThisArgument() and
node.asInstruction().(StoreInstruction).getSourceValue() = call.getThisArgument() and
encodeXercesFlowState(flowstate, 0, 1) // default configuration
)
}