hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 21:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Move ".."-parsing trick into AccessPathSyntax.qll

Browse Source
This commit is contained in:
Asger Feldthaus
2022-02-04 14:18:58 +01:00
parent 7c2cff3227
commit 30254686d8
4 changed files with 69 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
javascript/ql/test/library-tests/frameworks/data/test.expected
View File

@@ -71,3 +71,14 @@ isSink
| test.js:78:34:78:34 | 3 | test-sink |
| test.js:81:28:81:35 | source() | test-sink |
| test.js:82:28:82:28 | 1 | test-sink |
syntaxErrors
| Member[foo |
| Member[foo] .Member[bar] |
| Member[foo] Member[bar] |
| Member[foo], Member[bar] |
| Member[foo],Member[bar] |
| Member[foo]. Member[bar] |
| Member[foo]..Member[bar] |
| Member[foo]Member[bar] |
| Member[foo]] |
| Member[foo]].Member[bar] |

22
javascript/ql/test/library-tests/frameworks/data/test.ql
View File

@@ -1,5 +1,6 @@
import javascript
import testUtilities.ConsistencyChecking
import semmle.javascript.frameworks.data.internal.AccessPathSyntax as AccessPathSyntax
class Steps extends ModelInput::SummaryModelCsv {
override predicate row(string row) {
@@ -54,3 +55,24 @@ query predicate taintFlow(DataFlow::Node source, DataFlow::Node sink) {
query predicate isSink(DataFlow::Node node, string kind) {
node = ModelOutput::getASinkNode(kind).getARhs()
}
class SyntaxErrorTest extends ModelInput::SinkModelCsv {
override predicate row(string row) {
row = [
"testlib;;Member[foo],Member[bar];test-sink",
"testlib;;Member[foo] Member[bar];test-sink",
"testlib;;Member[foo]. Member[bar];test-sink",
"testlib;;Member[foo], Member[bar];test-sink",
"testlib;;Member[foo]..Member[bar];test-sink",
"testlib;;Member[foo] .Member[bar];test-sink",
"testlib;;Member[foo]Member[bar];test-sink",
"testlib;;Member[foo;test-sink",
"testlib;;Member[foo]];test-sink",
"testlib;;Member[foo]].Member[bar];test-sink"
]
}
}
query predicate syntaxErrors(AccessPathSyntax::AccessPath path) {
path.hasSyntaxError()
}