diff --git a/ql/src/experimental/integer-overflow-detection/RangeAnalysis.qll b/ql/src/experimental/integer-overflow-detection/RangeAnalysis.qll index 1d9cda5227f..89259fbc747 100644 --- a/ql/src/experimental/integer-overflow-detection/RangeAnalysis.qll +++ b/ql/src/experimental/integer-overflow-detection/RangeAnalysis.qll @@ -8,6 +8,7 @@ class LenFunction extends BuiltinFunction { Expr getAUse(SsaDefinition def) { result = def.getVariable().getAUse().(IR::EvalInstruction).getExpr() } + /* * calculate the upper bound of an expression */ diff --git a/ql/src/experimental/integer-overflow-detection/findOverflowExpr.ql b/ql/src/experimental/integer-overflow-detection/findOverflowExpr.ql index dd04d8bcffc..23682454c18 100644 --- a/ql/src/experimental/integer-overflow-detection/findOverflowExpr.ql +++ b/ql/src/experimental/integer-overflow-detection/findOverflowExpr.ql @@ -1,6 +1,6 @@ /** * @id go/integer-overflow-detection - * @name Find integer overflow + * @name Find integer overflow * @kind problem * @description This query is used to find the integer overflow problem that may occur when processing arithmetic operations in the program. Integer overflow often causes the results of the program to be incorrect, or the program crashes and exits. * @problem.severity error @@ -9,7 +9,6 @@ import go import RangeAnalysis - from Expr expr where exprMayOverflow(expr) or exprMayUnderflow(expr) select expr, "this expression may cause an integer overflow"