hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 19:56:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Asger F <asgerf@github.com>
This commit is contained in:
Erik Krogh Kristensen
2020-11-13 18:03:07 +01:00
committed by GitHub
parent 3ef5d89e39
commit 2f4fcc2f5e
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
javascript/ql/src/Performance/ReDoS.ql
View File

@@ -169,7 +169,7 @@ private predicate sharesRoot(TInputSymbol a, TInputSymbol b) {
}
/**
* Holds if the `a` is an inputsymbol from a regexp that has root `root`.
* Holds if the `a` is an input symbol from a regexp that has root `root`.
*/
private predicate belongsTo(TInputSymbol a, RegExpRoot root) {
exists(RegExpTerm term | getRoot(term) = root |
@@ -201,9 +201,15 @@ class InputSymbol extends TInputSymbol {
*/
abstract class CharacterClass extends InputSymbol {
/**
* Gets a char that is likely relevant for the ReDoS analysis of this character class.
* That is: One of the endpoints to the character class,
* or a char that is off-by-one to one of the endpoints of the character class (if this is an inversed character class).
* Gets a character that is relevant for intersection-tests involving this
* character class.
*
* Specifically, this is any of the characters mentioned explicitly in the
* character class, offset by one if it is inverted. For character class escapes,
* the result is as if the class had been written out as a series of intervals.
*
* This set is large enough to ensure that for any two intersecting character
* classes, one contains a relevant character from the other.
*/
abstract string getARelevantChar();