hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Move the query and examples over to 2/query-tests

Browse Source
This commit is contained in:
Rebecca Valentine
2020-02-20 16:31:58 -08:00
parent 376638e9c0
commit 2f3ea10cf8
4 changed files with 46 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
python/ql/test/2/query-tests/Expressions/TruncatedDivision.py Normal file
View File

@@ -0,0 +1,46 @@
#### TruncatedDivision.ql
# NOTE: The following test case will only work under Python 2.
# NOTE: While there are other files that have the same matching examples, this
# example file tries to explain the motivation of each example. Hopefully it's
# fine to have multiple such files.
# Truncated division occurs when two integers are divided. This causes the
# fractional part, if there is one, to be discared. So for example, `2 / 3` will
# evaluate to `0` instead of `0.666...`.
def truncated_division():
def average(l):
return sum(l) / len(l)
## Negative Cases
# This case is good, and is a minimal obvious case that should be good. It
# SHOULD NOT be found by the query.
print(3.0 / 2.0)
# This case is good, because the sum is `3.0`, which is a float, and will not
# truncate. This case SHOULD NOT be found by the query.
print(average([1.0, 2.0]))
## Positive Cases
# This case is bad, and is a minimal obvious case that should be bad. It
# SHOULD be found by the query.
print(3 / 2)
# This case is bad, because the sum is `3`, which is an integer, and will
# truncate when divided by the length `2`. This case SHOULD be found by the
# query.
#
# NOTE (2020-02-20):
# The current version of the Value/pointsTo API doesn't permit this detection,
# unfortunately, but we preserve this example in the hopes that future
# versions will catch it. That will necessitate changing the expected results.
print(average([1,2]))

1
python/ql/test/query-tests/Expressions/general/TruncatedDivision.expected
View File

@@ -1 +0,0 @@
| expressions_test.py:288:9:288:13 | BinaryExpr | Result of division may be truncated as its $@ and $@ arguments may both be integers. | expressions_test.py:288:9:288:9 | expressions_test.py:288 | left | expressions_test.py:288:13:288:13 | expressions_test.py:288 | right |

1
python/ql/test/query-tests/Expressions/general/TruncatedDivision.qlref
View File

@@ -1 +0,0 @@
Expressions/TruncatedDivision.ql

49
python/ql/test/query-tests/Expressions/general/expressions_test.py
View File

@@ -242,52 +242,3 @@ from types import MappingProxyType
def mpt_arg(d=MappingProxyType({})):
return 1 in d
#### TruncatedDivision.ql
# NOTE: The following test case will only work under Python 2.
# Truncated division occurs when two integers are divided. This causes the
# fractional part, if there is one, to be discared. So for example, `2 / 3` will
# evaluate to `0` instead of `0.666...`.
def truncated_division():
def average(l):
return sum(l) / len(l)
## Negative Cases
# This case is good, and is a minimal obvious case that should be good. It
# SHOULD NOT be found by the query.
print(3.0 / 2.0)
# This case is good, because the sum is `3.0`, which is a float, and will not
# truncate. This case SHOULD NOT be found by the query.
print(average([1.0, 2.0]))
## Positive Cases
# This case is bad, and is a minimal obvious case that should be bad. It
# SHOULD be found by the query.
print(3 / 2)
# This case is bad, because the sum is `3`, which is an integer, and will
# truncate when divided by the length `2`. This case SHOULD be found by the
# query.
print(average([1,2]))