hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: suggested refactor

Browse Source
This commit is contained in:
Rasmus Lerchedahl Petersen
2021-03-26 13:08:45 +01:00
parent 1be2be843d
commit 2e948da3b4
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
python/ql/src/Security/CWE-327/FluentApiModel.qll
View File

@@ -67,9 +67,8 @@ predicate unsafe_connection_creation(
}
/** A connection is created insecurely without reference to a context. */
predicate unsafe_context_creation(DataFlow::Node node, string insecure_version, CallNode call) {
predicate unsafe_context_creation(DataFlow::CallCfgNode call, string insecure_version) {
exists(TlsLibrary l, ContextCreation cc | cc = l.insecure_context_creation(insecure_version) |
cc = node and
cc.getNode() = call
cc = call
)
}

4
python/ql/src/Security/CWE-327/InsecureProtocol.ql
View File

@@ -37,7 +37,9 @@ from
where
unsafe_connection_creation(creation, insecure_version, contextOrigin, specific)
or
unsafe_context_creation(creation, insecure_version, contextOrigin.asCfgNode()) and specific = true
unsafe_context_creation(creation, insecure_version) and
contextOrigin = creation and
specific = true
select creation,
"Insecure SSL/TLS protocol version " + insecure_version + " " + verb(specific) + " by $@ ",
contextOrigin, originName(contextOrigin)