hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Refactor argument matching to use set literals

Browse Source 
Co-authored-by: Taus <tausbn@github.com>
This commit is contained in:
Rasmus Wriedt Larsen
2020-10-13 10:05:35 +02:00
committed by GitHub
parent d26a89b95e
commit 2e430325be
1 changed files with 5 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
python/ql/src/experimental/semmle/python/frameworks/Flask.qll
View File

@@ -157,14 +157,7 @@ private module Flask {
}
override DataFlow::Node getUrlPatternArg() {
exists(ControlFlowNode pattern_arg |
(
pattern_arg = call.getArg(0)
or
pattern_arg = call.getArgByName("rule")
) and
result.asCfgNode() = pattern_arg
)
result.asCfgNode() in [call.getArg(0), call.getArgByName("rule")]
}
override Function getARouteHandler() { result.getADecorator() = call.getNode() }
@@ -184,23 +177,13 @@ private module Flask {
}
override DataFlow::Node getUrlPatternArg() {
exists(ControlFlowNode pattern_arg |
(
pattern_arg = call.getArg(0)
or
pattern_arg = call.getArgByName("rule")
) and
result.asCfgNode() = pattern_arg
)
result.asCfgNode() in [call.getArg(0), call.getArgByName("rule")]
}
override Function getARouteHandler() {
exists(ControlFlowNode view_func_arg, DataFlow::Node func_src |
view_func_arg = call.getArg(2)
or
view_func_arg = call.getArgByName("view_func")
|
DataFlow::localFlow(func_src, any(DataFlow::Node dest | dest.asCfgNode() = view_func_arg)) and
exists(DataFlow::Node view_func_arg, DataFlow::Node func_src |
view_func_arg.asCfgNode() in [call.getArg(2), call.getArgByName("view_func")] and
DataFlow::localFlow(func_src, view_func_arg) and
func_src.asExpr().(CallableExpr) = result.getDefinition()
)
}