hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 03:36:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix that type inference assumed every compound-assignment have type number

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2021-01-20 15:26:39 +01:00
parent 2f459d9a72
commit 2e024c3c61
4 changed files with 22 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
javascript/ql/src/Expressions/ImplicitOperandConversion.ql
View File

@@ -130,13 +130,7 @@ class NumericConversion extends ImplicitConversion {
or
parent instanceof ArithmeticExpr and not parent instanceof AddExpr
or
parent instanceof CompoundAssignExpr and
not (
parent instanceof AssignAddExpr or
parent instanceof AssignLogOrExpr or
parent instanceof AssignLogAndExpr or
parent instanceof AssignNullishCoalescingExpr
)
parent.(CompoundAssignExpr).isNumeric()
or
parent instanceof UpdateExpr
}