hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 10:46:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Dataflow: Address review comment.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2021-03-16 11:07:33 +01:00
parent 5aa9c2bd19
commit 2d8d967060
23 changed files with 184 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
python/ql/src/semmle/python/dataflow/new/internal/DataFlowImpl.qll
View File

@@ -850,7 +850,7 @@ private module Stage2 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and
@@ -1489,7 +1489,7 @@ private module Stage3 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and
@@ -2133,8 +2133,11 @@ private module Stage4 {
bindingset[node, cc, config]
private LocalCc getLocalCc(Node node, Cc cc, Configuration config) {
localFlowEntry(node, config) and
result = getLocalCallContext(cc, getNodeEnclosingCallable(node))
exists(Cc cc0 |
cc = pragma[only_bind_into](cc0) and
localFlowEntry(node, config) and
result = getLocalCallContext(cc0, getNodeEnclosingCallable(node))
)
}
private predicate localStep(
@@ -2206,7 +2209,7 @@ private module Stage4 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and

13
python/ql/src/semmle/python/dataflow/new/internal/DataFlowImpl2.qll
View File

@@ -850,7 +850,7 @@ private module Stage2 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and
@@ -1489,7 +1489,7 @@ private module Stage3 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and
@@ -2133,8 +2133,11 @@ private module Stage4 {
bindingset[node, cc, config]
private LocalCc getLocalCc(Node node, Cc cc, Configuration config) {
localFlowEntry(node, config) and
result = getLocalCallContext(cc, getNodeEnclosingCallable(node))
exists(Cc cc0 |
cc = pragma[only_bind_into](cc0) and
localFlowEntry(node, config) and
result = getLocalCallContext(cc0, getNodeEnclosingCallable(node))
)
}
private predicate localStep(
@@ -2206,7 +2209,7 @@ private module Stage4 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and

13
python/ql/src/semmle/python/dataflow/new/internal/DataFlowImpl3.qll
View File

@@ -850,7 +850,7 @@ private module Stage2 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and
@@ -1489,7 +1489,7 @@ private module Stage3 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and
@@ -2133,8 +2133,11 @@ private module Stage4 {
bindingset[node, cc, config]
private LocalCc getLocalCc(Node node, Cc cc, Configuration config) {
localFlowEntry(node, config) and
result = getLocalCallContext(cc, getNodeEnclosingCallable(node))
exists(Cc cc0 |
cc = pragma[only_bind_into](cc0) and
localFlowEntry(node, config) and
result = getLocalCallContext(cc0, getNodeEnclosingCallable(node))
)
}
private predicate localStep(
@@ -2206,7 +2209,7 @@ private module Stage4 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and

13
python/ql/src/semmle/python/dataflow/new/internal/DataFlowImpl4.qll
View File

@@ -850,7 +850,7 @@ private module Stage2 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and
@@ -1489,7 +1489,7 @@ private module Stage3 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and
@@ -2133,8 +2133,11 @@ private module Stage4 {
bindingset[node, cc, config]
private LocalCc getLocalCc(Node node, Cc cc, Configuration config) {
localFlowEntry(node, config) and
result = getLocalCallContext(cc, getNodeEnclosingCallable(node))
exists(Cc cc0 |
cc = pragma[only_bind_into](cc0) and
localFlowEntry(node, config) and
result = getLocalCallContext(cc0, getNodeEnclosingCallable(node))
)
}
private predicate localStep(
@@ -2206,7 +2209,7 @@ private module Stage4 {
ap = getApNil(node)
or
exists(Node mid, Ap ap0, LocalCc localCc |
fwdFlow(mid, pragma[only_bind_into](cc), argAp, ap0, config) and
fwdFlow(mid, cc, argAp, ap0, config) and
localCc = getLocalCc(mid, cc, config)
|
localStep(mid, node, true, _, config, localCc) and