hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-20 10:46:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Cleanup, docs, and an extra test case

Browse Source
This commit is contained in:
Taus Brock-Nannestad
2020-09-16 14:46:04 +02:00
parent 7cdd290b90
commit 2d3e23ebb0
3 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
python/ql/src/experimental/dataflow/internal/DataFlowPrivate.qll
View File

@@ -240,6 +240,7 @@ class DataFlowClassValue extends DataFlowCallable, TClassValue {
override string getName() { result = c.getName() }
}
/** A class representing the scope in which a `ModuleVariableNode` appears. */
class DataFlowModuleScope extends DataFlowCallable, TModule {
Module mod;

7
python/ql/src/experimental/dataflow/internal/DataFlowPublic.qll
View File

@@ -150,6 +150,7 @@ class ParameterNode extends EssaNode {
override DataFlowCallable getEnclosingCallable() { this.isParameterOf(result, _) }
}
/** A data flow node corresponding to a module-level (global) variable that is accessed outside of the module scope. */
class ModuleVariableNode extends Node, TModuleVariableNode {
Module mod;
GlobalVariable var;
@@ -176,10 +177,8 @@ class ModuleVariableNode extends Node, TModuleVariableNode {
}
/** Gets an `EssaNode` that corresponds to an assignment of this global variable. */
Node getAWrite() {
exists(DefinitionNode defn |
result.asVar().getDefinition().(EssaNodeDefinition).definedBy(var, defn)
)
EssaNode getAWrite() {
result.asVar().getDefinition().(EssaNodeDefinition).definedBy(var, any(DefinitionNode defn))
}
override DataFlowCallable getEnclosingCallable() { result.(DataFlowModuleScope).getScope() = mod }