hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove toString taint propagation

Browse Source 
We do not do this for other overrides of toString
This commit is contained in:
Owen Mansel-Chan
2021-08-09 16:42:38 +01:00
parent 487a46ae77
commit 2d31bb8d64
2 changed files with 0 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/ql/src/semmle/code/java/frameworks/apache/Collections.qll
View File

@@ -68,7 +68,6 @@ private class ApacheCollectionsModel extends SummaryModelCsv {
";FluentIterable;true;skip;;;Element of Argument[-1];Element of ReturnValue;value",
";FluentIterable;true;toArray;;;Element of Argument[-1];ArrayElement of ReturnValue;value",
";FluentIterable;true;toList;;;Element of Argument[-1];Element of ReturnValue;value",
";FluentIterable;true;toString;;;Element of Argument[-1];ReturnValue;taint",
";FluentIterable;true;unique;;;Element of Argument[-1];Element of ReturnValue;value",
";FluentIterable;true;unmodifiable;;;Element of Argument[-1];Element of ReturnValue;value",
";FluentIterable;true;zip;(Iterable);;Element of Argument[-1];Element of ReturnValue;value",
@@ -148,16 +147,12 @@ private class ApacheKeyValueModel extends SummaryModelCsv {
".keyvalue;AbstractKeyValue;true;setKey;;;Argument[0];MapKey of Argument[-1];value",
".keyvalue;AbstractKeyValue;true;setValue;;;MapValue of Argument[-1];ReturnValue;value",
".keyvalue;AbstractKeyValue;true;setValue;;;Argument[0];MapValue of Argument[-1];value",
".keyvalue;AbstractKeyValue;true;toString;;;MapKey of Argument[-1];ReturnValue;taint",
".keyvalue;AbstractKeyValue;true;toString;;;MapValue of Argument[-1];ReturnValue;taint",
".keyvalue;AbstractMapEntry;true;AbstractMapEntry;;;Argument[0];MapKey of Argument[-1];value",
".keyvalue;AbstractMapEntry;true;AbstractMapEntry;;;Argument[1];MapValue of Argument[-1];value",
".keyvalue;AbstractMapEntryDecorator;true;AbstractMapEntryDecorator;;;MapKey of Argument[0];MapKey of Argument[-1];value",
".keyvalue;AbstractMapEntryDecorator;true;AbstractMapEntryDecorator;;;MapValue of Argument[0];MapValue of Argument[-1];value",
".keyvalue;AbstractMapEntryDecorator;true;getMapEntry;;;MapKey of Argument[-1];MapKey of ReturnValue;value",
".keyvalue;AbstractMapEntryDecorator;true;getMapEntry;;;MapValue of Argument[-1];MapValue of ReturnValue;value",
".keyvalue;AbstractMapEntryDecorator;true;toString;;;MapKey of Argument[-1];ReturnValue;taint",
".keyvalue;AbstractMapEntryDecorator;true;toString;;;MapValue of Argument[-1];ReturnValue;taint",
".keyvalue;DefaultKeyValue;true;DefaultKeyValue;(Object,Object);;Argument[0];MapKey of Argument[-1];value",
".keyvalue;DefaultKeyValue;true;DefaultKeyValue;(Object,Object);;Argument[1];MapValue of Argument[-1];value",
".keyvalue;DefaultKeyValue;true;DefaultKeyValue;(KeyValue);;MapKey of Argument[0];MapKey of Argument[-1];value",
@@ -389,7 +384,6 @@ private class ApacheIteratorUtilsModel extends SummaryModelCsv {
";IteratorUtils;true;toArray;;;Element of Argument[0];ArrayElement of ReturnValue;value",
";IteratorUtils;true;toList;;;Element of Argument[0];Element of ReturnValue;value",
";IteratorUtils;true;toListIterator;;;Element of Argument[0];Element of ReturnValue;value",
";IteratorUtils;true;toString;;;Element of Argument[0];ReturnValue;taint",
";IteratorUtils;true;toString;;;Argument[2];ReturnValue;taint",
";IteratorUtils;true;toString;;;Argument[3];ReturnValue;taint",
";IteratorUtils;true;toString;;;Argument[4];ReturnValue;taint",
@@ -441,7 +435,6 @@ private class ApacheIterableUtilsModel extends SummaryModelCsv {
";IterableUtils;true;reversedIterable;;;Element of Argument[0];Element of ReturnValue;value",
";IterableUtils;true;skippingIterable;;;Element of Argument[0];Element of ReturnValue;value",
";IterableUtils;true;toList;;;Element of Argument[0];Element of ReturnValue;value",
";IterableUtils;true;toString;;;Element of Argument[0];ReturnValue;taint",
";IterableUtils;true;toString;;;Argument[2];ReturnValue;taint",
";IterableUtils;true;toString;;;Argument[3];ReturnValue;taint",
";IterableUtils;true;toString;;;Argument[4];ReturnValue;taint",

77
java/ql/test/library-tests/frameworks/apache-collections/Test.java
View File

@@ -315,20 +315,6 @@ public class Test {
out = in.mySetValue((Object)null);
sink(out); // $ hasValueFlow
}
{
// "org.apache.commons.collections4.keyvalue;AbstractKeyValue;true;toString;;;MapKey of Argument[-1];ReturnValue;taint"
String out = null;
AbstractKeyValue in = newMAKVWithMapKey((String)source());
out = in.toString();
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4.keyvalue;AbstractKeyValue;true;toString;;;MapValue of Argument[-1];ReturnValue;taint"
String out = null;
AbstractKeyValue in = newMAKVWithMapValue((String)source());
out = in.toString();
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4.keyvalue;AbstractMapEntry;true;AbstractMapEntry;;;Argument[0];MapKey of Argument[-1];value"
AbstractMapEntry out = null;
@@ -371,20 +357,6 @@ public class Test {
out = in.myGetMapEntry();
sink(getMapValueFromEntry(out)); // $ hasValueFlow
}
{
// "org.apache.commons.collections4.keyvalue;AbstractMapEntryDecorator;true;toString;;;MapKey of Argument[-1];ReturnValue;taint"
String out = null;
AbstractMapEntryDecorator in = newMAMEDWithMapKey((String)source());
out = in.toString();
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4.keyvalue;AbstractMapEntryDecorator;true;toString;;;MapValue of Argument[-1];ReturnValue;taint"
String out = null;
AbstractMapEntryDecorator in = newMAMEDWithMapValue((String)source());
out = in.toString();
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4.keyvalue;DefaultKeyValue;true;DefaultKeyValue;(Entry);;MapKey of Argument[0];MapKey of Argument[-1];value"
DefaultKeyValue out = null;
@@ -1763,13 +1735,6 @@ public class Test {
out = in.toList();
sink(getElement(out)); // $ hasValueFlow
}
{
// "org.apache.commons.collections4;FluentIterable;true;toString;;;Element of Argument[-1];ReturnValue;taint"
String out = null;
FluentIterable in = newFluentIterableWithElement((String)source());
out = in.toString();
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4;FluentIterable;true;unique;;;Element of Argument[-1];Element of ReturnValue;value"
FluentIterable out = null;
@@ -2178,27 +2143,6 @@ public class Test {
out = IterableUtils.toList(in);
sink(getElement(out)); // $ hasValueFlow
}
{
// "org.apache.commons.collections4;IterableUtils;true;toString;;;Element of Argument[0];ReturnValue;taint"
String out = null;
Iterable in = newVectorWithElement((String)source());
out = IterableUtils.toString(in, null, null, null, null);
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4;IterableUtils;true;toString;;;Element of Argument[0];ReturnValue;taint"
String out = null;
Iterable in = newVectorWithElement((String)source());
out = IterableUtils.toString(in, null);
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4;IterableUtils;true;toString;;;Element of Argument[0];ReturnValue;taint"
String out = null;
Iterable in = newVectorWithElement((String)source());
out = IterableUtils.toString(in);
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4;IterableUtils;true;toString;;;Argument[2];ReturnValue;taint"
String out = null;
@@ -2598,27 +2542,6 @@ public class Test {
out = IteratorUtils.toListIterator(in);
sink(getElement(out)); // $ hasValueFlow
}
{
// "org.apache.commons.collections4;IteratorUtils;true;toString;;;Element of Argument[0];ReturnValue;taint"
String out = null;
Iterator in = newListIteratorWithElement((String)source());
out = IteratorUtils.toString(in, null, null, null, null);
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4;IteratorUtils;true;toString;;;Element of Argument[0];ReturnValue;taint"
String out = null;
Iterator in = newListIteratorWithElement((String)source());
out = IteratorUtils.toString(in, null);
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4;IteratorUtils;true;toString;;;Element of Argument[0];ReturnValue;taint"
String out = null;
Iterator in = newListIteratorWithElement((String)source());
out = IteratorUtils.toString(in);
sink(out); // $ hasTaintFlow
}
{
// "org.apache.commons.collections4;IteratorUtils;true;toString;;;Argument[2];ReturnValue;taint"
String out = null;