hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-22 23:35:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve query quality

Browse Source
This commit is contained in:
Tamas Vajk
2025-07-02 11:19:10 +02:00
parent e0cb1792bd
commit 2cd0c64e41
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
java/ql/src/Violations of Best Practice/Records/UselessMembersOfTheRecordsClass.ql
View File

@@ -1,8 +1,9 @@
/**
* @id java/useless-members-of-the-records-class
* @name Useless serialization members of `Records`
* @description Using certain members of the `Records` class during serialization will result in
* @id java/useless-member-of-the-record-class
* @name Useless serialization member of record class
* @description Using certain members of a record class during serialization will result in
* those members being ignored.
* @previous-id java/useless-members-of-the-records-class
* @kind problem
* @precision very-high
* @problem.severity warning
@@ -20,4 +21,5 @@ where
"writeObject", "readObject", "readObjectNoData", "writeExternal", "readExternal",
"serialPersistentFields"
])
select record, "Declaration of useless member $@ found.", m, m.getName()
select m, "Useless serialization member $@ found in record class $@.", m, m.getName(), record,
record.getName()

12
java/ql/test/query-tests/UselessMembersOfTheRecordsClass/UselessMembersOfTheRecordsClass.expected
View File

@@ -1,6 +1,6 @@
| Test.java:4:12:4:13 | T1 | Declaration of useless member $@ found. | Test.java:7:46:7:67 | serialPersistentFields | serialPersistentFields |
| Test.java:4:12:4:13 | T1 | Declaration of useless member $@ found. | Test.java:10:18:10:28 | writeObject | writeObject |
| Test.java:4:12:4:13 | T1 | Declaration of useless member $@ found. | Test.java:13:18:13:27 | readObject | readObject |
| Test.java:4:12:4:13 | T1 | Declaration of useless member $@ found. | Test.java:16:18:16:33 | readObjectNoData | readObjectNoData |
| Test.java:21:12:21:13 | T2 | Declaration of useless member $@ found. | Test.java:24:17:24:29 | writeExternal | writeExternal |
| Test.java:21:12:21:13 | T2 | Declaration of useless member $@ found. | Test.java:28:17:28:28 | readExternal | readExternal |
| Test.java:7:46:7:67 | serialPersistentFields | Useless serialization member $@ found in record class $@. | Test.java:7:46:7:67 | serialPersistentFields | serialPersistentFields | Test.java:4:12:4:13 | T1 | T1 |
| Test.java:10:18:10:28 | writeObject | Useless serialization member $@ found in record class $@. | Test.java:10:18:10:28 | writeObject | writeObject | Test.java:4:12:4:13 | T1 | T1 |
| Test.java:13:18:13:27 | readObject | Useless serialization member $@ found in record class $@. | Test.java:13:18:13:27 | readObject | readObject | Test.java:4:12:4:13 | T1 | T1 |
| Test.java:16:18:16:33 | readObjectNoData | Useless serialization member $@ found in record class $@. | Test.java:16:18:16:33 | readObjectNoData | readObjectNoData | Test.java:4:12:4:13 | T1 | T1 |
| Test.java:24:17:24:29 | writeExternal | Useless serialization member $@ found in record class $@. | Test.java:24:17:24:29 | writeExternal | writeExternal | Test.java:21:12:21:13 | T2 | T2 |
| Test.java:28:17:28:28 | readExternal | Useless serialization member $@ found in record class $@. | Test.java:28:17:28:28 | readExternal | readExternal | Test.java:21:12:21:13 | T2 | T2 |