hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6720 from aschackmull/java/isunreachableincall-joinorder

Browse Source 
Java: Fix join-order in isUnreachableInCall.
This commit is contained in:
Anders Schack-Mulligen
2021-09-21 16:07:42 +02:00
committed by GitHub
parent dd1bed02e8 c72e385a47
commit 2c41de6648
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
View File

@@ -294,7 +294,7 @@ predicate isUnreachableInCall(Node n, DataFlowCall call) {
Guard guard
|
// get constant bool argument and parameter for this call
viableParamArg(call, paramNode, arg) and
viableParamArg(call, pragma[only_bind_into](paramNode), arg) and
// get the ssa variable definition for this parameter
param.isParameterDefinition(paramNode.getParameter()) and
// which is used in a guard
@@ -302,7 +302,7 @@ predicate isUnreachableInCall(Node n, DataFlowCall call) {
// which controls `n` with the opposite value of `arg`
guard
.controls(n.asExpr().getBasicBlock(),
pragma[only_bind_out](arg.getBooleanValue()).booleanNot())
pragma[only_bind_into](pragma[only_bind_out](arg.getBooleanValue()).booleanNot()))
)
}