hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #21599 from aschackmull/csharp/constantcondition-simplify

Browse Source 
C#: Simplify the ConstantCondition query.
This commit is contained in:
Anders Schack-Mulligen
2026-03-31 11:02:30 +02:00
committed by GitHub
parent 71b38b71bf 29500c7eb7
commit 2bde364bdd
25 changed files with 109 additions and 265 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
csharp/ql/lib/semmle/code/csharp/commons/Constants.qll
View File

@@ -4,19 +4,6 @@ import csharp
private import semmle.code.csharp.commons.ComparisonTest
private import semmle.code.csharp.commons.StructuralComparison as StructuralComparison
pragma[noinline]
private predicate isConstantCondition0(ControlFlow::Node cfn, boolean b) {
exists(cfn.getASuccessorByType(any(ControlFlow::BooleanSuccessor t | t.getValue() = b))) and
strictcount(ControlFlow::SuccessorType t | exists(cfn.getASuccessorByType(t))) = 1
}
/**
* Holds if `e` is a condition that always evaluates to Boolean value `b`.
*/
predicate isConstantCondition(Expr e, boolean b) {
forex(ControlFlow::Node cfn | cfn = e.getAControlFlowNode() | isConstantCondition0(cfn, b))
}
/**
* Holds if comparison operation `co` is constant with the Boolean value `b`.
* For example, the comparison `x > x` is constantly `false` in