Ruby: Tidy an exists

2026-04-30 11:15:13 +02:00 · 2022-03-18 14:43:45 +00:00
parent 62bc0357ea
commit 2bd25da8e3
1 changed files with 1 additions and 3 deletions
--- a/ruby/ql/lib/codeql/ruby/security/OpenSSL.qll
+++ b/ruby/ql/lib/codeql/ruby/security/OpenSSL.qll
@@ -378,7 +378,7 @@ private class CipherInstantiation extends CipherCallNode {
  private CipherMode cipherMode;

  CipherInstantiation() {
-    exists(string cipherName |
+    exists(string cipherName | cipher.matchesName(cipherName) |
      // `OpenSSL::Cipher.new('<cipherName>')`
      this = cipherApi().getAnInstantiation() and
      cipherName = this.getStringArgument(0) and
@@ -436,8 +436,6 @@ private class CipherInstantiation extends CipherCallNode {
          cipherMode.isBlockMode(blockMode)
        )
      )
-    |
-      cipher.matchesName(cipherName)
    )
  }