Java: Don't clear content in store steps in summaries.

2026-06-22 21:27:04 +02:00 · 2021-11-19 14:22:28 +01:00
parent 62730e7a4b
commit 2b1f34ed9b
2 changed files with 2 additions and 3 deletions
--- a/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
+++ b/java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
@@ -150,8 +150,7 @@ predicate readStep(Node node1, Content f, Node node2) {
 * in `x.f = newValue`.
 */
 predicate clearsContent(Node n, Content c) {
-  c instanceof FieldContent and
-  n = any(PostUpdateNode pun | storeStep(_, c, pun)).getPreUpdateNode()
+  exists(FieldAccess fa | instanceFieldAssign(_, fa) and n = getFieldQualifier(fa))
  or
  FlowSummaryImpl::Private::Steps::summaryClearsContent(n, c)
 }