hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-19 02:13:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Reintroduce the AST testing configuration for the smart pointer test too

Browse Source
This commit is contained in:
Jeroen Ketema
2022-11-15 13:49:03 +01:00
parent 3d94286785
commit 2acda03518
2 changed files with 27 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
cpp/ql/test/library-tests/dataflow/smart-pointers-taint/taint.ql
View File

@@ -1,5 +1,24 @@
import TestUtilities.dataflow.FlowTestCommon
module AstTest {
private import semmle.code.cpp.dataflow.old.TaintTracking
class AstSmartPointerTaintConfig extends TaintTracking::Configuration {
AstSmartPointerTaintConfig() { this = "ASTSmartPointerTaintConfig" }
override predicate isSource(DataFlow::Node source) {
source.asExpr().(FunctionCall).getTarget().getName() = "source"
}
override predicate isSink(DataFlow::Node sink) {
exists(FunctionCall call |
call.getTarget().getName() = "sink" and
sink.asExpr() = call.getAnArgument()
)
}
}
}
module IRTest {
private import semmle.code.cpp.ir.dataflow.TaintTracking

16
cpp/ql/test/library-tests/dataflow/smart-pointers-taint/test.cpp
View File

@@ -7,8 +7,8 @@ void test_unique_ptr_int() {
std::unique_ptr<int> p1(new int(source()));
std::unique_ptr<int> p2 = std::make_unique<int>(source());
sink(*p1); // $ ir
sink(*p2); // $ ir=8:50
sink(*p1); // $ ir MISSING: ast
sink(*p2); // $ ast ir=8:50
}
struct A {
@@ -21,9 +21,9 @@ void test_unique_ptr_struct() {
std::unique_ptr<A> p1(new A{source(), 0});
std::unique_ptr<A> p2 = std::make_unique<A>(source(), 0);
sink(p1->x); // $ ir
sink(p1->x); // $ ir MISSING: ast
sink(p1->y);
sink(p2->x); // $ ir=22:46
sink(p2->x); // $ ir=22:46 MISSING: ast
sink(p2->y);
}
@@ -31,16 +31,16 @@ void test_shared_ptr_int() {
std::shared_ptr<int> p1(new int(source()));
std::shared_ptr<int> p2 = std::make_shared<int>(source());
sink(*p1); // $ ir
sink(*p2); // $ ir=32:50
sink(*p1); // $ ast,ir
sink(*p2); // $ ast ir=32:50
}
void test_shared_ptr_struct() {
std::shared_ptr<A> p1(new A{source(), 0});
std::shared_ptr<A> p2 = std::make_shared<A>(source(), 0);
sink(p1->x); // $ MISSING: ir
sink(p1->x); // $ MISSING: ast,ir
sink(p1->y);
sink(p2->x); // $ MISSING: ir
sink(p2->x); // $ MISSING: ast,ir
sink(p2->y);
}