hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant tests.

Browse Source
This commit is contained in:
Mark Shannon
2019-04-17 13:04:35 +01:00
parent 4145b19671
commit 2aa967ae8e
8 changed files with 32 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
python/ql/src/semmle/python/pointsto/PointsTo.qll
View File

@@ -1705,16 +1705,10 @@ cached module Types {
or
exists(cls.(PythonClassObjectInternal).getScope().getADecorator()) and not six_add_metaclass(_, cls, _) and reason = "Decorator not understood"
or
exists(int i |
exists(cls.(PythonClassObjectInternal).getScope().getBase(i)) and reason = "Missing base " + i
|
not exists(getBase(cls, i))
)
reason = "Missing base " + missingBase(cls)
or
exists(cls.(PythonClassObjectInternal).getScope().getMetaClass()) and not exists(cls.getClass()) and reason = "Failed to infer metaclass"
or
exists(int i | failedInference(getBase(cls, i), _) and reason = "Failed inference for base class at position " + i)
or
exists(int i, ObjectInternal base1, ObjectInternal base2 |
base1 = getBase(cls, i) and
base2 = getBase(cls, i) and
@@ -1722,7 +1716,24 @@ cached module Types {
reason = "Multiple bases at position " + i
)
or
exists(int i, int j | getBase(cls, i) = getBase(cls, j) and i != j and reason = "Duplicate bases classes")
duplicateBase(cls) and reason = "Duplicate bases classes"
or
not exists(getMro(cls)) and reason = "Failed to compute MRO" and not exists(missingBase(cls)) and not duplicateBase(cls)
or
exists(int i | failedInference(getBase(cls, i), _) and reason = "Failed inference for base class at position " + i)
}
private int missingBase(ClassObjectInternal cls) {
exists(cls.(PythonClassObjectInternal).getScope().getBase(result))
and
not exists(getBase(cls, result)) or getBase(cls, result) = ObjectInternal::unknownClass()
}
private predicate duplicateBase(ClassObjectInternal cls) {
exists(int i, int j, ClassObjectInternal dup |
dup = getBase(cls, i) and dup != ObjectInternal::unknownClass() and
dup = getBase(cls, j) and i != j
)
}
cached boolean improperSubclass(ObjectInternal sub, ObjectInternal sup) {

5
python/ql/src/semmle/python/security/TaintTracking.qll
View File

@@ -1204,11 +1204,10 @@ library module TaintFlowImplementation {
exists(ParameterDefinition def |
def.getDefiningNode() = param and
exists(CallableValue func, CallNode call |
call.getFunction().pointsTo() = func and
callee = caller.getCallee(call) |
exists(int n | param = func.getParameter(n) and argument = call.getArg(n))
exists(int n | param = func.getParameter(n) and argument = func.getArgumentForCall(call, n))
or
exists(string name | param = func.getParameterByName(name) and argument = call.getArgByName(name))
exists(string name | param = func.getParameterByName(name) and argument = func.getNamedArgumentForCall(call, name))
or
class_initializer_argument(_, _, call, func, argument, param)
)