hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Tom Hvitved <hvitved@github.com>
This commit is contained in:
Alex Ford
2021-06-24 19:43:35 +01:00
committed by GitHub
parent a45366e426
commit 2a7d8bbc0a
1 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ql/src/codeql_ruby/dataflow/internal/TaintTrackingPrivate.qll
View File

@@ -23,18 +23,9 @@ predicate defaultAdditionalTaintStep(DataFlow::Node nodeFrom, DataFlow::Node nod
)
or
// string interpolation of `nodeFrom` into `nodeTo`
exists(
CfgNodes::ExprNodes::StringlikeLiteralCfgNode lit,
CfgNodes::ExprNodes::StringInterpolationComponentCfgNode sic
|
lit = nodeTo.asExpr() and
sic = lit.getAComponent() and
sic = nodeFrom.asExpr()
)
nodeFrom.asExpr() =
nodeTo.asExpr().(CfgNodes::ExprNodes::StringlikeLiteralCfgNode).getAComponent()
or
// element reference from nodeFrom
exists(CfgNodes::ExprNodes::ElementReferenceCfgNode ref |
ref = nodeTo.asExpr() and
ref.getReceiver() = nodeFrom.asExpr()
)
nodeFrom.asExpr() = nodeTo.asExpr().(CfgNodes::ExprNodes::ElementReferenceCfgNode).getReceiver()
}