From 2a224719752cf76a35cb840da0c09dbc39b7f597 Mon Sep 17 00:00:00 2001
From: Esben Sparre Andreasen <esben@semmle.com>
Date: Mon, 9 Sep 2019 10:31:40 +0200
Subject: [PATCH] JS: address review comments

---
 .../src/com/semmle/js/extractor/ExtractionMetrics.java      | 2 +-
 .../ql/src/semmle/javascript/meta/ExtractionMetrics.qll     | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/javascript/extractor/src/com/semmle/js/extractor/ExtractionMetrics.java b/javascript/extractor/src/com/semmle/js/extractor/ExtractionMetrics.java
index 3e9844faf25..d77f71f04ce 100644
--- a/javascript/extractor/src/com/semmle/js/extractor/ExtractionMetrics.java
+++ b/javascript/extractor/src/com/semmle/js/extractor/ExtractionMetrics.java
@@ -46,7 +46,7 @@ public class ExtractionMetrics {
   /** The label for the file that is being extracted. */
   private Label fileLabel;
 
-  /** The number of characters in the file that is being extracted. */
+  /** The number of UTF16 code units in the file that is being extracted. */
   private int length;
 
   /** The previous time a CPU-time measure was performed. */
diff --git a/javascript/ql/src/semmle/javascript/meta/ExtractionMetrics.qll b/javascript/ql/src/semmle/javascript/meta/ExtractionMetrics.qll
index da66e4cbf6b..2e21a3122b3 100644
--- a/javascript/ql/src/semmle/javascript/meta/ExtractionMetrics.qll
+++ b/javascript/ql/src/semmle/javascript/meta/ExtractionMetrics.qll
@@ -25,12 +25,12 @@ module ExtractionMetrics {
     float getWallclockTime() { result = strictsum(getTime(_, 1)) }
 
     /**
-     * Gets the CPU time in nanoseconds it took to process phase `phaseName` during the extraction this file.
+     * Gets the CPU time in nanoseconds it took to process phase `phaseName` during the extraction of this file.
      */
     float getCpuTime(PhaseName phaseName) { result = getTime(phaseName, 0) }
 
     /**
-     * Gets the wall-clock time in nanoseconds it took to process phase `phaseName` during the extraction this file.
+     * Gets the wall-clock time in nanoseconds it took to process phase `phaseName` during the extraction of this file.
      */
     float getWallclockTime(PhaseName phaseName) { result = getTime(phaseName, 1) }
 
@@ -45,7 +45,7 @@ module ExtractionMetrics {
     string getCacheFile() { extraction_data(this, result, _, _) }
 
     /**
-     * Gets the number of characters in this file.
+     * Gets the number of UTF16 code units in this file.
      */
     int getLength() { extraction_data(this, _, _, result) }