hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Simplify

Browse Source
This commit is contained in:
Nora Dimitrijević
2022-09-29 23:06:17 +02:00
parent 891bc342be
commit 2a046352ce
1 changed files with 11 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
cpp/ql/src/Best Practices/Likely Errors/CommaBeforeMisleadingIndentation.ql
View File

@@ -17,20 +17,12 @@ import semmle.code.cpp.commons.Exclusions
* ThisExpr.isCompilerGenerated() is currently not being extracted, so use a heuristic. * ThisExpr.isCompilerGenerated() is currently not being extracted, so use a heuristic.
*/ */
predicate isCompilerGenerated(ThisExpr te) { predicate isCompilerGenerated(ThisExpr te) {
exists( exists(int line, int colStart, int colEnd |
string filepath, int line, int colStart, int colEnd, boolean zeroDiff, boolean sameLocAsCall te.getLocation().hasLocationInfo(_, line, colStart, line, colEnd)
| |
te.getLocation().hasLocationInfo(filepath, line, colStart, line, colEnd) and colStart = colEnd
(if colStart = colEnd then zeroDiff = true else zeroDiff = false) and
(
if exists(Call c | c.getQualifier() = te | c.getLocation() = te.getLocation())
then sameLocAsCall = true
else sameLocAsCall = false
)
|
zeroDiff = true
or or
zeroDiff = false and sameLocAsCall = true exists(Call c | c.getQualifier() = te | c.getLocation() = te.getLocation())
) )
} }
@@ -47,28 +39,18 @@ Expr normalizeExpr(Expr e) {
else result = e else result = e
} }
predicate isInLoopHead(CommaExpr ce) { predicate isParenthesized(CommaExpr ce) {
ce.getParent*().(Expr).isParenthesised()
or
ce.isUnevaluated() // sizeof(), decltype(), alignof(), noexcept(), typeid()
or
ce.getParent*() = any(IfStmt i).getCondition()
or
ce.getParent*() = [any(Loop l).getCondition(), any(ForStmt f).getUpdate()] ce.getParent*() = [any(Loop l).getCondition(), any(ForStmt f).getUpdate()]
or or
ce.getEnclosingStmt() = any(ForStmt f).getInitialization() ce.getEnclosingStmt() = any(ForStmt f).getInitialization()
} }
predicate isInDecltypeOrSizeof(CommaExpr ce) {
ce.getParent*() instanceof SizeofExprOperator
or
ce.getParent*() = any(Decltype d).getExpr()
}
predicate isParenthesized(CommaExpr ce) {
isInLoopHead(ce)
or
isInDecltypeOrSizeof(ce)
or
ce.getParent*().(Expr).isParenthesised()
or
ce.getParent*() = any(IfStmt i).getCondition()
}
from CommaExpr ce, Expr left, Expr right, Location leftLoc, Location rightLoc from CommaExpr ce, Expr left, Expr right, Location leftLoc, Location rightLoc
where where
ce.fromSource() and ce.fromSource() and