hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 08:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Add: taint step to handle propagation of data flow from the array to callback

Browse Source
This commit is contained in:
Napalys
2024-11-19 14:15:15 +01:00
parent f1e95a8a1d
commit 28ead4011a
3 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
javascript/ql/lib/semmle/javascript/Arrays.qll
View File

@@ -492,7 +492,20 @@ private module ArrayLibraries {
exists(DataFlow::MethodCallNode call |
call.getMethodName() = ["findLast", "find", "findLastIndex"] and
prop = arrayLikeElement() and
obj = call.getReceiver() and
obj = call.getReceiver().getALocalSource() and
element = call.getCallback(0).getParameter(0)
)
}
}
/**
* This step models the propagation of data from the array to the callback function's parameter.
*/
private class ArrayCallBackDataTaintStep extends TaintTracking::SharedTaintStep {
override predicate step(DataFlow::Node obj, DataFlow::Node element) {
exists(DataFlow::MethodCallNode call |
call.getMethodName() = ["findLast", "find", "findLastIndex"] and
obj = call.getReceiver().getALocalSource() and
element = call.getCallback(0).getParameter(0)
)
}

3
javascript/ql/test/library-tests/Arrays/TaintFlow.expected
View File

@@ -35,5 +35,8 @@
| arrays.js:120:19:120:26 | "source" | arrays.js:121:46:121:49 | item |
| arrays.js:120:19:120:26 | "source" | arrays.js:122:10:122:16 | element |
| arrays.js:126:19:126:26 | "source" | arrays.js:127:55:127:58 | item |
| arrays.js:131:17:131:24 | source() | arrays.js:132:46:132:49 | item |
| arrays.js:131:17:131:24 | source() | arrays.js:133:10:133:17 | element1 |
| arrays.js:137:17:137:24 | source() | arrays.js:138:50:138:53 | item |
| arrays.js:137:17:137:24 | source() | arrays.js:139:10:139:17 | element1 |
| arrays.js:143:17:143:24 | source() | arrays.js:144:55:144:58 | item |

6
javascript/ql/test/library-tests/Arrays/arrays.js
View File

@@ -129,19 +129,19 @@
}
{
const arr = source();
const element1 = arr.find((item) => sink(item)); // NOT OK - only found with taint-tracking.
const element1 = arr.find((item) => sink(item)); // NOT OK
sink(element1); // NOT OK
}
{
const arr = source();
const element1 = arr.findLast((item) => sink(item)); // NOT OK - only found with taint-tracking.
const element1 = arr.findLast((item) => sink(item)); // NOT OK
sink(element1); // NOT OK
}
{
const arr = source();
const element1 = arr.findLastIndex((item) => sink(item)); // NOT OK - only found with taint-tracking.
const element1 = arr.findLastIndex((item) => sink(item)); // NOT OK
sink(element1); // OK
}
});