fix non-monotonic recursion in js/missing-rate-limiting

This commit is contained in:
Erik Krogh Kristensen
2021-08-31 14:21:46 +02:00
parent 83252e5ba2
commit 28dce6e95a

View File

@@ -29,7 +29,7 @@ private import semmle.javascript.frameworks.ConnectExpressShared::ConnectExpress
/**
* A route handler that should be rate-limited.
*/
abstract class ExpensiveRouteHandler extends HTTP::RouteHandler {
abstract class ExpensiveRouteHandler extends DataFlow::Node {
Express::RouteHandler impl;
ExpensiveRouteHandler() { this = impl }
@@ -42,10 +42,6 @@ abstract class ExpensiveRouteHandler extends HTTP::RouteHandler {
* `referenceLabel` are ignored and should be bound to dummy values.
*/
abstract predicate explain(string explanation, DataFlow::Node reference, string referenceLabel);
override HTTP::HeaderDefinition getAResponseHeader(string name) {
result = impl.getAResponseHeader(name)
}
}
/**