hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix frontend errors that Go complained about

Browse Source
This commit is contained in:
erik-krogh
2024-05-16 20:06:26 +02:00
parent 08c0d8ec60
commit 2848ccf0e2
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
go/ql/test/query-tests/Security/CWE-078/CommandInjection2.go
View File

@@ -9,15 +9,15 @@ import (
"regexp"
)
func handler(req *http.Request) {
func handlerExample(req *http.Request) {
imageName := req.URL.Query()["imageName"][0]
outputPath = "/tmp/output.svg"
outputPath := "/tmp/output.svg"
cmd := exec.Command("sh", "-c", fmt.Sprintf("imagetool %s > %s", imageName, outputPath)) // NOT OK - correctly flagged
cmd.Run()
// ...
}
func handler2(req *http.Request) {
func handlerExample2(req *http.Request) {
imageName := req.URL.Query()["imageName"][0]
outputPath := "/tmp/output.svg"
@@ -37,7 +37,7 @@ func handler2(req *http.Request) {
cmd.Run()
}
func handler3(req *http.Request) {
func handlerExample3(req *http.Request) {
imageName := req.URL.Query()["imageName"][0]
outputPath := "/tmp/output.svg"