hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Tom Hvitved
2021-12-08 11:26:44 +01:00
parent 490872173a
commit 283173ad02
13 changed files with 87 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplCommon.qll
View File

@@ -391,14 +391,11 @@ private module Cached {
/**
* Holds if `p` is the parameter of a viable dispatch target of `call`,
* and `p` matches arguments at position `apos`.
* and `p` has position `ppos`.
*/
pragma[nomagic]
private predicate viableParam(DataFlowCall call, ArgumentPosition apos, ParamNode p) {
exists(ParameterPosition ppos |
p.isParameterOf(viableCallableExt(call), ppos) and
parameterMatch(ppos, apos)
)
private predicate viableParam(DataFlowCall call, ParameterPosition ppos, ParamNode p) {
p.isParameterOf(viableCallableExt(call), ppos)
}
/**
@@ -407,9 +404,9 @@ private module Cached {
*/
cached
predicate viableParamArg(DataFlowCall call, ParamNode p, ArgNode arg) {
exists(ArgumentPosition pos |
viableParam(call, pos, p) and
arg.argumentOf(call, pos) and
exists(ParameterPosition ppos |
viableParam(call, ppos, p) and
argumentPositionMatch(call, arg, ppos) and
compatibleTypes(getNodeDataFlowType(arg), getNodeDataFlowType(p))
)
}