hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

add .getALocalSource() when testing for lodash-members

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2019-10-14 14:14:26 +02:00
parent a7c1c34e1e
commit 28056791a5
3 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/src/Statements/UseOfReturnlessFunction.ql
View File

@@ -113,8 +113,8 @@ DataFlow::SourceNode array(DataFlow::TypeTracker t) {
DataFlow::SourceNode array() { result = array(DataFlow::TypeTracker::end()) }
predicate voidArrayCallback(DataFlow::MethodCallNode call, Function func) {
hasNonVoidCallbackMethod(call.getMethodName()) and
predicate voidArrayCallback(DataFlow::CallNode call, Function func) {
hasNonVoidCallbackMethod(call.getCalleeName()) and
func = call.getAnArgument().getALocalSource().asExpr() and
1 = count(DataFlow::Node arg | arg = call.getAnArgument() and arg.getALocalSource().asExpr() instanceof Function) and
returnsVoid(func) and
@@ -123,7 +123,7 @@ predicate voidArrayCallback(DataFlow::MethodCallNode call, Function func) {
(
call.getReceiver().getALocalSource() = array()
or
call.getCalleeNode() instanceof LodashUnderscore::Member
call.getCalleeNode().getALocalSource() instanceof LodashUnderscore::Member
)
}