hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Exclude loop conditions from overflow check heuristic.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2019-10-18 11:58:46 +02:00
parent 066a2f0d12
commit 27b8a46dac
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
java/ql/src/Likely Bugs/Comparison/UselessComparisonTest.ql
View File

@@ -168,10 +168,14 @@ Expr increaseOrDecreaseOfVar(SsaVariable v) {
}
predicate overFlowTest(ComparisonExpr comp) {
exists(SsaVariable v | comp.hasOperands(increaseOrDecreaseOfVar(v), v.getAUse()))
or
comp.getLesserOperand() = overFlowCand() and
comp.getGreaterOperand().(IntegerLiteral).getIntValue() = 0
(
exists(SsaVariable v | comp.hasOperands(increaseOrDecreaseOfVar(v), v.getAUse()))
or
comp.getLesserOperand() = overFlowCand() and
comp.getGreaterOperand().(IntegerLiteral).getIntValue() = 0
) and
// exclude loop conditions as they are unlikely to be overflow tests
not comp.getEnclosingStmt() instanceof LoopStmt
}
predicate concurrentModificationTest(BinaryExpr test) {