hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 10:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16457 from owen-mc/go/fix-implicitvarargsslice-type

Browse Source 
Go: Fix `getType` on `ImplicitVarArgsSlice`
This commit is contained in:
Owen Mansel-Chan
2024-05-08 20:52:01 +01:00
committed by GitHub
parent 0cbedfb28c 4d42a88c3c
commit 279b2c7a95
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
go/ql/lib/change-notes/2024-05-08-fix-flow-variadic-builtin-variable.md Normal file
View File

@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Fixed a bug that stopped data flow from being followed through variadic arguments to built-in functions or to functions called using a variable.

4
go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
View File

@@ -455,8 +455,8 @@ module Public {
CallNode getCallNode() { result = call }
override Type getType() {
exists(Function f | f = call.getTarget() |
result = f.getParameterType(f.getNumParameter() - 1)
exists(SignatureType t | t = call.getCall().getCalleeType() |
result = t.getParameterType(t.getNumParameter() - 1)
)
}